Skip to content

Strengthen resolve-missing #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 28, 2021
Merged

Strengthen resolve-missing #336

merged 6 commits into from
Sep 28, 2021

Conversation

vemv
Copy link
Member

@vemv vemv commented Sep 25, 2021

Fixes #335

  • Remove slam.hound.future
    • The functions provided by it are expected to be present in all end users' environments.
    • (Especially since rewrite-clj now has a min requirement of Clojure 1.8)
  • Multiple fixes for refactor-nrepl.ns.slam.hound.search
    • Handle delay correctly
    • Handle separators correctly for Windows
    • Use a classpath value that will work
    • Filter out more Clojure auto-generated classes
    • Remove 'namespace' finding functionality, we don't use it (as we use all-ns instead) so it was confusing.
  • Remove unused code from refactor-nrepl.ns.slam.hound.regrow

The functions provided by it are expected to be present in all end users' environments.

(Especially since rewrite-clj now has a min requirement of Clojure 1.8)
* Handle `delay` correctly
* Handle separators correctly for Windows
* Use a classpath value that will work
* Filter out more Clojure auto-generated classes
* Remove namespaces functionality, we don't use it (as we use `all-ns` instead) so it was confusing.

Fixes #335
@vemv vemv requested a review from a team September 25, 2021 04:58
@bbatsov
Copy link
Member

bbatsov commented Sep 27, 2021

Good changes overall, but I guess it's time to drop this code structure with the copied slamhound namespaces and just put everything new need under refactor-nrepl.ns or something like this. slamhound is dead and buried at this point and the current code structure is confusing for people not familiar with how we got where we are. A good opportunity to simplify things. Perhaps down the road some of this stuff can go to orchard? We'll see.

@vemv
Copy link
Member Author

vemv commented Sep 27, 2021

Good remark, I think that over time I'll be moving/proposing new functionality to Orchard so that it fulfills its original purpose optimally.

@vemv
Copy link
Member Author

vemv commented Sep 27, 2021

Ready again

@bbatsov bbatsov merged commit d3760be into master Sep 28, 2021
@bbatsov bbatsov deleted the 335--resolve-missing branch September 28, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize resolve-missing
2 participants