Optimize ast-stats (#397)

Most of all, I was worried about `(keys asts)` and `(vals asts)` used in a coupled manner. It's plausible that their returned order may be inconsistent across those two individual invocations.

Author: vemv

src/refactor_nrepl/analyzer.clj

@@ -130,13 +130,20 @@
       ast-or-err)))
 
 (defn- ast-stats []
-  (let [asts @ast-cache]
-    (interleave (keys asts)
-                (->> (vals asts)
-                     (mapcat vals)
-                     (map #(if (instance? Throwable %)
-                             (list "error" (.getMessage ^Throwable %))
-                             "OK"))))))
+  (let [asts @ast-cache
+        map-entries (seq asts)]
+    (reduce (fn [acc [k v]]
+              (conj acc
+                    (->> v
+                         vals
+                         (reduce (fn [init x]
+                                   (if (instance? Throwable x)
+                                     (reduced (list "error" (.getMessage ^Throwable x)))
+                                     init))
+                                 "OK"))
+                    k))
+            ()
+            map-entries)))
 
 (defn warm-ast-cache []
   (doseq [f (tracker/project-files-in-topo-order true)]

test/refactor_nrepl/analyzer_test.clj

@@ -1,6 +1,7 @@
 (ns refactor-nrepl.analyzer-test
   (:require
    [clojure.java.io :as io]
+   [clojure.pprint :as pprint]
    [clojure.test :refer [deftest is]]
    [refactor-nrepl.analyzer :as sut]))
 
@@ -9,3 +10,14 @@
              "clashing_defprotocol_method_name.clj"]
           :let [c (-> f io/resource slurp)]]
     (is (some? (sut/ns-ast c)))))
+
+(deftest warm-ast-cache-test
+  (let [pairs (partition 2 (sut/warm-ast-cache))]
+    (when (System/getenv "CI")
+      (pprint/pprint pairs))
+    (doseq [[ns-sym result] pairs]
+      (is (simple-symbol? ns-sym))
+      (is (or (= "OK" result)
+              (and (list? result)
+                   (-> result first #{"error"})
+                   (-> result second string?)))))))