Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1dba82f] On error don't auto-jump to tooling files #962

Merged
merged 1 commit into from
Feb 1, 2015

Conversation

vspinu
Copy link
Contributor

@vspinu vspinu commented Feb 1, 2015

The reversion to eval broke auto-jumping functionality. For example C-c C-e after

(def tt []
  (/ dfd 0))

jumps to form-init file.

@bbatsov
Copy link
Member

bbatsov commented Feb 1, 2015

The code looks good, but it needs a changelog entry.

@vspinu
Copy link
Contributor Author

vspinu commented Feb 1, 2015

The code looks good, but it needs a changelog entry.

Do you use clearcut rules of when to add a change log and when not? Would be good to know. It seem that now every commit needs a changelog. Quite a lot of redundant typing IMO.

By any standards, this is a small fix for a small recent regression. Why would an end user be interested to read this in a change log?

@bbatsov
Copy link
Member

bbatsov commented Feb 1, 2015

Do you use clearcut rules of when to add a change log and when not? Would be good to know. It seem that now every commit needs a changelog. Quite a lot of redundant typing IMO.

Yes. If some commit fixes a bug, introduces a change in existing user-visible behaviour or adds a new user-visible feature it should have a changelog entry.

By any standards, this is a small fix for a small recent regression. Why would an end user be interested to read this in a change log?

I'm definitely interested in reading about such fixes and I'm pretty sure I'm not the only one. End users rarely read commits, but they usually like a good changelog/release notes.

bbatsov added a commit that referenced this pull request Feb 1, 2015
[1dba82f] On error don't auto-jump to tooling files
@bbatsov bbatsov merged commit 5766957 into clojure-emacs:master Feb 1, 2015
@vspinu vspinu deleted the form-init branch August 1, 2017 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants