[profile] Update to latest profiling middleware #3805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-yakushev
force-pushed
the
profile
branch
from
a6d7266 to
6e7d62e
Compare
alexander-yakushev
force-pushed
the
profile
branch
3 times, most recently
from
3fa06e6 to
8c84d21
Compare
bbatsov
approved these changes
Apr 10, 2025
There was a problem hiding this comment.
Looks good to me overall. Perhaps you can also mention somewhere what are the limitations of the built-in profiler, so it's clearer when it's a good idea for people to use it and when to reach out to a proper profiler.
Perhaps now that you're on a roll you'll finally integrate clj-async-profiler with CIDER. 😀
bbatsov
reviewed
Apr 10, 2025
| CIDER has a built-in profiler that can help you identify hot-spots in your | ||
| application code. It's built on top of the https://github.com/thunknyc/profile[thunknyc/profile] library. | ||
| CIDER has a simple built-in profiler that can you to quickly measure the running | ||
| time of individual functions. |
There was a problem hiding this comment.
Perhaps add some comparison with time as in many ways our "profiler" is just a fancy interface for time (at least in my mind).
bbatsov
reviewed
Apr 10, 2025
| @@ -34,7 +34,6 @@ | |||
| (require 'cider-client) | |||
| (require 'cider-eval) | |||
| (require 'cider-scratch) | |||
| (require 'cider-profile) | |||
There was a problem hiding this comment.
I can't believe we had a dependency here for one var. :D
alexander-yakushev
force-pushed
the
profile
branch
from
8c84d21 to
01df376
Compare
bbatsov
reviewed
Apr 10, 2025
| application code. It's built on top of the https://github.com/thunknyc/profile[thunknyc/profile] library. | ||
| CIDER has a simple built-in profiler that can you to quickly measure the running | ||
| time of individual functions. It is similar to wrapping your functions with | ||
| `time` macro, except it records every timing and displays a the summarized |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PRs: clojure-emacs/orchard#333, clojure-emacs/cider-nrepl#929
Final touches. Remove functions for the removed ops, display summary with the inspector, update docs.