Handle Windows filenames in cider-compilation-regex #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks OK to me. I'd change the second commit message to |
juergenhoetzel
force-pushed
the
master
branch
from
e3638bb
to
a8caa21
Compare
|
That makes sense: I amended the commit. |
|
I still don't see a changelog entry. |
The previous regex was too restrictive: Windows file names always contain a colon.
juergenhoetzel
force-pushed
the
master
branch
from
a8caa21
to
0da920d
Compare
|
😞 Sorry missed out changelog entry in previous commit: Amended again. |
bbatsov
added a commit
that referenced
this pull request
Oct 27, 2015
Handle Windows filenames in cider-compilation-regex
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.