PR feedback

Author: vemv

CHANGELOG.md

@@ -10,7 +10,7 @@
 - [#3522](https://github.com/clojure-emacs/cider/issues/3522): Introduce a new possible value for [`cider-use-overlays`](https://docs.cider.mx/cider/usage/code_evaluation.html#overlays): `errors-only`.
   - If specified, only errors will result in an overlay being shown.
 - [#3527](https://github.com/clojure-emacs/cider/issues/3527): Preserve the font size as one navigates through the CIDER inspector.
-- [#3525](https://github.com/clojure-emacs/cider/issues/3525): Introduce [`cider-shorten-error-overlays`](https://docs.cider.mx/cider/usage/code_evaluation.html#overlays) customization option.
+- [#3525](https://github.com/clojure-emacs/cider/issues/3525): Introduce [`cider-inline-error-message-function`](https://docs.cider.mx/cider/usage/code_evaluation.html#overlays) customization option.
 
 ## 1.8.2 (2023-10-15)
 

cider-eval.el

@@ -821,13 +821,15 @@ REPL buffer.  This is controlled via
                                                      conn)))
           (nrepl-dict-get result "phase"))))))
 
-(defcustom cider-shorten-error-overlays t
-  "If t, overlays that reflect error messages will be more concise.
-Specifically, the prefix matched by `cider-clojure-compilation-regexp',
-and the suffix matched by `cider-module-info-regexp' will be removed."
+(defcustom cider-inline-error-message-function #'cider--shorten-error-message
+  "A function that will shorten a given error message,
+as shown in overlays / the minibuffer (per `cider-use-overlays').
+
+The function takes a single arg.  You may want to use `identity',
+for leaving the message as-is."
   :type 'boolean
   :group 'cider
-  :package-version '(cider . "0.19.0"))
+  :package-version '(cider . "1.19.0"))
 
 (defun cider--shorten-error-message (err)
   "Removes from ERR the prefix matched by `cider-clojure-compilation-regexp',
@@ -874,9 +876,7 @@ when `cider-auto-inspect-after-eval' is non-nil."
                                                  (member phase cider-clojure-compilation-error-phases)))
                                        ;; Display errors as temporary overlays
                                        (let ((cider-result-use-clojure-font-lock nil)
-                                             (trimmed-err (if cider-shorten-error-overlays
-                                                              (cider--shorten-error-message err)
-                                                            err)))
+                                             (trimmed-err (funcall cider-inline-error-message-function err)))
                                          (cider--display-interactive-eval-result
                                           trimmed-err
                                           'error

doc/modules/ROOT/pages/usage/code_evaluation.adoc

@@ -208,12 +208,14 @@ bottom) with the `cider-use-overlays` variable:
 ----
 
 Overlays that indicate errors are by default trimmed of file/line/phase information.
-If you find it useful, you can customize:
 
+(Example: the entire `Syntax error compiling at (src/ns.clj:227:3).` preamble)
+
+You can prevent any trimming by customizing instead:
 
 [source,lisp]
 ----
-(setq cider-shorten-error-overlays nil)
+(setq cider-inline-error-message-function #'identity)
 ----
 
 By default, result overlays are displayed at the end of the line. You can set