Marks MutTxId as !Send
#3972
Open
Marks MutTxId as !Send
#3972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubham8287
commented
Jan 8, 2026
| let reschedule = delete_scheduled_function_row(Some(tx), Some((timestamp, instant))); | ||
| }; | ||
|
|
||
| // Below code is outside of the DB transaction scope because the |
Contributor
Author
There was a problem hiding this comment.
this code has to be refactored only to make compiler believe that it doesn't hold tx across await, whcih were already not happening here.
| /// such as: | ||
| /// https://github.com/clockworklabs/SpacetimeDB/pull/3938 and | ||
| /// https://github.com/clockworklabs/SpacetimeDB/pull/3968. | ||
| unsafe impl Send for InstanceEnv {} |
Collaborator
There was a problem hiding this comment.
Very helpful comment. I still have some reservations about having to mark this unsafe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Depends on #3968.
Makes
MutTxId,!Sendto avoid being deadlocked by holding it acrossawaitpointsafter taking learnings from #3938 and #3968.
API and ABI breaking changes
NA
Expected complexity level and risk
1, It only increases the compile time safety.
Testing
Existing should be enough.