fix automigration bug with auto_inc
#3862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubham8287
force-pushed
the
shub/fix-auto-inc-migration-bug
branch
from
7ec0359 to
6d17084
Compare
Centril
approved these changes
Dec 10, 2025
Contributor
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
Looks good, but from_i128 can be slightly simplified though. Approved with the below changes made.
Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Signed-off-by: Shubham Mishra <shivam828787@gmail.com>
jdetter
pushed a commit
that referenced
this pull request
Dec 10, 2025
# Description of Changes fixes #3861. While running prechecks for automigration, the `range` passed to `iter_by_col_range_mut` was of type `AlgebraicValue::I128`, even though it should have matched the column’s type. Fix is straightforward by introducing `AlgebraicValue::from_i128` helper. # API and ABI breaking changes NA # Expected complexity level and risk 1 # Testing - Modified smoketest to repro reported bug. --------- Signed-off-by: Shubham Mishra <shivam828787@gmail.com> Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com>
jdetter
changed the title
auto_inc auto_inc
jdetter
pushed a commit
that referenced
this pull request
Dec 10, 2025
# Description of Changes fixes #3861. While running prechecks for automigration, the `range` passed to `iter_by_col_range_mut` was of type `AlgebraicValue::I128`, even though it should have matched the column’s type. Fix is straightforward by introducing `AlgebraicValue::from_i128` helper. # API and ABI breaking changes NA # Expected complexity level and risk 1 # Testing - Modified smoketest to repro reported bug. --------- Signed-off-by: Shubham Mishra <shivam828787@gmail.com> Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
fixes #3861.
While running prechecks for automigration, the
rangepassed toiter_by_col_range_mutwas of typeAlgebraicValue::I128, even though it should have matched the column’s type.Fix is straightforward by introducing
AlgebraicValue::from_i128helper.API and ABI breaking changes
NA
Expected complexity level and risk
1
Testing