-
Notifications
You must be signed in to change notification settings - Fork 663
[Rust] Query builder Integration. #3823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubham8287
commented
Dec 4, 2025
Shubham8287
commented
Dec 4, 2025
joshua-spacetime
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Patch contain few different things, required to run query builder end to end.
Git history seems messed up but it can be reviewed commitwise from - 69c1907.
Tfrom table name, as type represents thestructand not table, and there couple be multiple tables implemented from same struct.traitsand types required for query builder,FromWhere(as originalExprwere referencing to original table names).API and ABI breaking changes
Add
Query<T>type as Views return type.Expected complexity level and risk
2, changes are simple but not splitted up well.
Testing
TODO:
ui test.