Skip to content

Conversation

@Shubham8287
Copy link
Contributor

@Shubham8287 Shubham8287 commented Dec 4, 2025

Description of Changes

Patch contain few different things, required to run query builder end to end.
Git history seems messed up but it can be reviewed commitwise from - 69c1907.

  1. Decouples generic type T from table name, as type represents the struct and not table, and there couple be multiple tables implemented from same struct.
  2. modify table macro implementaiton to generate code supporting traits and types required for query builder,
  3. Disable aliasing in sql queries for now, as it was causing semantically wrong query when we were doing joins on FromWhere (as original Expr were referencing to original table names).
  4. smoketests.

API and ABI breaking changes

Add Query<T> type as Views return type.

Expected complexity level and risk

2, changes are simple but not splitted up well.

Testing

  1. Added smoketest.

TODO:
ui test.

@joshua-spacetime joshua-spacetime linked an issue Dec 4, 2025 that may be closed by this pull request
@Shubham8287 Shubham8287 changed the title Rust: Query builder Integration. [Rust] Query builder Integration. Dec 4, 2025
@joshua-spacetime joshua-spacetime added this pull request to the merge queue Dec 4, 2025
Merged via the queue into master with commit c99a613 Dec 4, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Rust] Module bindings for query builder

3 participants