Store SubscriptionMetrics for Update, Subscribe, Unsubscribe in ModuleSubscriptions
#3821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubham8287
approved these changes
Dec 4, 2025
Centril
changed the title
SubscriptionMetrics for Update, Subscribe, Unsubscribe in ModuleSubscriptions`SubscriptionMetrics for Update, Subscribe, Unsubscribe in ModuleSubscriptions
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
…in `ModuleSubscriptions` (#3821) # Description of Changes This showed up in flamegraphs, in particular for `Update`, so let's cache the `SubscriptionMetrics`s. # API and ABI breaking changes None # Expected complexity level and risk 1 # Testing Covered by existing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This showed up in flamegraphs, in particular for
Update, so let's cache theSubscriptionMetricss.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
Covered by existing tests.