[Rust] update module bindings to use new view abi #3819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/switch-view-bindings-to-new-abi
branch
from
99d2259 to
2f56bc7
Compare
Shubham8287
approved these changes
Dec 4, 2025
Contributor
Shubham8287
left a comment
Shubham8287
left a comment
There was a problem hiding this comment.
Thank you for this, looks good!
joshua-spacetime
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Updates the rust module bindings to use new view abi (
ViewResultHeader) and updates the return codes for the__call_view__and__call_view_anon__module exports. This is in preparation forQuerybuilder support.API and ABI breaking changes
Not breaking. Existing modules will continue to use the old abi. New modules will use the new abi. However previous host versions will not support modules built using this version of the bindings.
Expected complexity level and risk
2
Testing
This is an internal refactor. All existing tests should continue to pass. The only tests that needed updating were the negative module compilation tests because the error messages produced by rustc changed.