Implement DbContext for AnonymousViewContext and ViewContext #3787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tamaro Skaljic <49238587+tamaro-skaljic@users.noreply.github.com>
Contributor
Author
|
@JulienLavocat Would you mind reviewing or delegating to a co-worker from you? I need the change to support views in SpacetimeDSL. |
|
|
Collaborator
|
@tamaro-skaljic can you sign the cla again? |
Contributor
Author
|
@joshua-spacetime Done. |
joshua-spacetime
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The trait has already been implemented for ReducerContext and TxContext, but implementation for AnonymousViewContext and ViewContext is still missing.
Background why I need this change
In SpacetimeDSL, I currently have the ReducerContext hard-coded as a prerequisite for creating a DSL instance (see https://github.com/tamaro-skaljic/SpacetimeDSL/blob/main/src/lib.rs#L9-L33) .
With the addition of
I am now faced with the dilemma that I also have to support SpacetimeDSL with the other contexts.
I hope to be able to use
spacetimedb::DbContext<DbView = spacetimedb::Local>andspacetimedb::DbContext<DbView = spacetimedb::LocalReadOnly>as a common denominator.(I signed the CLA)
API and ABI breaking changes
No
Expected complexity level and risk
1