Skip to content

Conversation

@coolreader18
Copy link
Collaborator

@coolreader18 coolreader18 commented Nov 25, 2025

Description of Changes

Expected complexity level and risk

2

Testing

  • The types for generated module bindings look right
  • Actually test the client behavior (how?)

@coolreader18 coolreader18 force-pushed the noa/ts-client-procedures branch from 476709c to 8f85c3a Compare November 25, 2025 22:36
@coolreader18 coolreader18 marked this pull request as ready for review November 25, 2025 22:36
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very straightforward, I would love to just rename subtypes and then I'm good to approve.

Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now LGTM

@coolreader18 coolreader18 added this pull request to the merge queue Nov 26, 2025
Merged via the queue into master with commit 174f528 Nov 26, 2025
36 of 37 checks passed
@coolreader18 coolreader18 deleted the noa/ts-client-procedures branch November 26, 2025 18:31
@joshua-spacetime joshua-spacetime linked an issue Dec 1, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Procedures: TypeScript client SDK invocation interface

3 participants