Fix realtime update for views #3747
Merged
+57
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/fix/realtime-update-for-views
branch
from
3343757 to
996f49f
Compare
joshua-spacetime
force-pushed
the
joshua/fix/realtime-update-for-views
branch
from
71b592f to
dd38e2b
Compare
joshua-spacetime
force-pushed
the
joshua/fix/realtime-update-for-views
branch
2 times, most recently
from
6ca298e to
a84be71
Compare
joshua-spacetime
added
bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
View tables have private metadata columns that need to be dropped before sending results to clients. Before this patch we dropped these columns for sql queries and initial subscriptions, but we didn't drop them after incremental update which is what this patch does.
API and ABI breaking changes
None
Expected complexity level and risk
1
Testing