Fix spacetime generate running dotnet format in the wrong directory
#3687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t format` in the wrong directory
jdetter
approved these changes
Nov 18, 2025
Collaborator
jdetter
left a comment
jdetter
left a comment
There was a problem hiding this comment.
I read the context in discord on the smoke test hang issue and this change makes sense. Pending the smoke tests passing this lgtm though I haven't tested it myself. Thanks for the help debugging on this one Zeke 🙏
mamcx
pushed a commit
that referenced
this pull request
Nov 18, 2025
…ry (#3687) # Description of Changes `spacetime generate` calls `dotnet format`.. but it did so with `--folder`, without going to any particular directory. The result would be that `dotnet format` tries to format _whatever directory it was run from. # API and ABI breaking changes None. # Expected complexity level and risk 1 # Testing - [x] `python3 -m smoketests namespaces` no longer hangs on my machine --------- Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 19, 2025
# Description of Changes Apparently, when `spacetime generate` passes files to a linter, the files are passed in as relative paths, which did not play properly with `dotnet format` (so we effectively borked it). # API and ABI breaking changes None. # Expected complexity level and risk 1 # Testing - [x] Unity testsuite no longer fails on expected diffs --------- Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
spacetime generatecallsdotnet format.. but it did so with--folder, without going to any particular directory. The result would be thatdotnet formattries to format _whatever directory it was run from.API and ABI breaking changes
None.
Expected complexity level and risk
1
Testing
python3 -m smoketests namespacesno longer hangs on my machine