Fix the basic-rust client template for CLI's init command #3646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This template was never properly tested, and it contains wrong API usage that can't even compile
cloutiertyler
approved these changes
Nov 12, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 17, 2025
# Description of Changes This template was never properly tested, and it contains wrong API usage that can't even compile. The only problem is that in order to make it work the person table has to be public, and I'm not sure if we want to make that change. Alternatively we could make basic-rust code not subscribe to anything and just connect to the database. # Expected complexity level and risk 2 # Testing - [x] I compiled the template and checked that it works against
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This template was never properly tested, and it contains wrong API usage that can't even compile.
The only problem is that in order to make it work the person table has to be public, and I'm not sure if we want to make that change. Alternatively we could make basic-rust code not subscribe to anything and just connect to the database.
Expected complexity level and risk
2
Testing