Skip to content

Conversation

@Shubham8287
Copy link
Contributor

@Shubham8287 Shubham8287 commented Nov 7, 2025

Description of Changes

Problem is visible in replication smoketests, which exit and re-lauch modules, erorring out with:

ERROR /app/public/crates/core/src/host/host_controller.rs:818: Failed to open database: DatabaseError: Database is already opened. Path:`/stdb/data/replicas/4`. Error:Resource temporarily unavailable (os error 11).: Database is already opened. Path:`/stdb/data/replicas/4`. Error:Resource temporarily unavailable (os error 11)

Commented code will be a blocker for releasing Views but we want CIs to pass.

@kim
Copy link
Contributor

kim commented Nov 7, 2025

I can confirm that it fixes the issue, but it remains unclear why the receiver is not dropped.

@Shubham8287 Shubham8287 added this pull request to the merge queue Nov 7, 2025
@Shubham8287
Copy link
Contributor Author

Shubham8287 commented Nov 7, 2025

ModuleSubscription::module_rx: OnceLock<watch::Receiver<ModuleHost>>,

Here reciever holds the recent instance of ModuleHost and which internally again contains the ModuleSubscriptions, so drop is not being called due to circular dependency.

I am fixing it for View in separate PR.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2025
@Shubham8287 Shubham8287 added this pull request to the merge queue Nov 7, 2025
Merged via the queue into master with commit 1d04930 Nov 7, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants