fix: view index #3596
Merged
fix: view index #3596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses - #3487 (comment). Can be reviewed commit wise. 1. Provide `ModuleSubscriptions` a interface to invoke `ModuleHost::call_view`. 2. Handle `st_view_client table` insertion. 3. Make views available form sql.
Shubham8287
force-pushed
the
shub/views-fix-view-index
branch
from
1c0746a to
c8ccbc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
call_viewandcall_view_anonmaintains separateVeclist for view inside Module butModuleDefused to have singleVec. Hence, Views index is not same acrossModuleDefand module itself.Added a
indexfield insideViewDefwhich stores it index inside module.API and ABI breaking changes
NA
How complicated do you think these changes are? Grade on a scale from 1 to 5,
2,
there could be some existing code relying on poistion in
Vecand may not appear as compiler errorTesting
Future smoketests should cover this.