Skip to content

Conversation

@mamcx
Copy link
Contributor

@mamcx mamcx commented Nov 4, 2025

Description of Changes

Disconnects clients when adding, removing, or updating RLS rules. Client are not disconnected if an auto-migration does not touch any RLS rules.

Why do we need to disconnect clients at all?

Subscriptions cache RLS rules. By disconnecting clients, we forcibly evict stale invalid RLS rules from the cache.

API and ABI breaking changes

Bug fix. Previously subscriptions would keep stale RLS rules in cache.

Expected complexity level and risk

1

Testing

  • Adding unit and smoke tests
  • Manual inspection with spacetime subscribe

@mamcx mamcx self-assigned this Nov 4, 2025
@mamcx mamcx added the release-any To be landed in any release window label Nov 4, 2025
@mamcx mamcx force-pushed the mamcx/rls-disconnect-clients branch 2 times, most recently from 11c4134 to 4245ae5 Compare November 4, 2025 20:46
@mamcx mamcx force-pushed the mamcx/rls-disconnect-clients branch from 4245ae5 to 0041eca Compare November 5, 2025 15:48
@mamcx mamcx force-pushed the mamcx/rls-disconnect-clients branch from 0041eca to 8dab9b7 Compare November 6, 2025 16:08
Signed-off-by: joshua-spacetime <josh@clockworklabs.io>
Signed-off-by: joshua-spacetime <josh@clockworklabs.io>
@joshua-spacetime joshua-spacetime added this pull request to the merge queue Nov 11, 2025
Merged via the queue into master with commit 08a00ef Nov 11, 2025
25 checks passed
@joshua-spacetime joshua-spacetime deleted the mamcx/rls-disconnect-clients branch November 19, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants