[TS] Fix ctx.timestamp serialization #3461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
approved these changes
Oct 22, 2025
Collaborator
joshua-spacetime
left a comment
joshua-spacetime
left a comment
There was a problem hiding this comment.
A regression test will be added as part of the quickstart smoketest
2 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
bfops
pushed a commit
that referenced
this pull request
Oct 27, 2025
# Description of Changes Resolves #3433. The issue was caused by the fact we were calling `serialize_to_js` with a full `Timestamp` struct, not just an `i64`. In the future I'd like to move away from the use of `serialize_to_js` to avoid problems like this. # API and ABI breaking changes Technically a breaking change, but fixes a bug. # Expected complexity level and risk 1 # Testing <!-- Describe any testing you've done, and any testing you'd like your reviewers to do, so that you're confident that all the changes work as expected! --> - [x] Checked to ensure `ctx.timestamp` is correct. - [ ] <!-- maybe a test you want a reviewer to do, so they can check it off when they're satisfied. -->
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2025
# Description of Changes Based on #3461, which fixes a bug encountered in the quickstart. # API and ABI breaking changes <!-- If this is an API or ABI breaking change, please apply the corresponding GitHub label. --> n/a # Expected complexity level and risk <!-- How complicated do you think these changes are? Grade on a scale from 1 to 5, where 1 is a trivial change, and 5 is a deep-reaching and complex change. This complexity rating applies not only to the complexity apparent in the diff, but also to its interactions with existing and future code. If you answered more than a 2, explain what is complex about the PR, and what other components it interacts with in potentially concerning ways. --> 1 # Testing <!-- Describe any testing you've done, and any testing you'd like your reviewers to do, so that you're confident that all the changes work as expected! --> - [x] Yes - [ ] <!-- maybe a test you want a reviewer to do, so they can check it off when they're satisfied. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Resolves #3433. The issue was caused by the fact we were calling
serialize_to_jswith a fullTimestampstruct, not just ani64. In the future I'd like to move away from the use ofserialize_to_jsto avoid problems like this.API and ABI breaking changes
Technically a breaking change, but fixes a bug.
Expected complexity level and risk
1
Testing
ctx.timestampis correct.