Skip to content

Conversation

@bfops
Copy link
Collaborator

@bfops bfops commented Oct 21, 2025

Description of Changes

The previews only work for public repos, meaning that the posts end up looking inconsistent. I don't believe the previews add much information anyway. If there's information in there that we want, we should add it to the post itself.

API and ABI breaking changes

No.

Expected complexity level and risk

1

Testing

None. We'll see when it merges!

@bfops bfops added release-any To be landed in any release window no runtime change This change does not affect the final binaries labels Oct 21, 2025
@bfops bfops requested a review from jdetter October 21, 2025 17:13
@bfops bfops changed the title Remove previews on discord posts for merged PRs CI Remove previews on discord posts for merged PRs Oct 21, 2025
@bfops bfops changed the title CI Remove previews on discord posts for merged PRs CI - Remove previews on discord posts for merged PRs Oct 21, 2025
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small change, LGTM 👍

@bfops bfops added this pull request to the merge queue Oct 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2025
@bfops bfops added this pull request to the merge queue Oct 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2025
@bfops bfops added this pull request to the merge queue Oct 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2025
@bfops bfops added this pull request to the merge queue Oct 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2025
@bfops bfops added this pull request to the merge queue Oct 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2025
@bfops bfops added this pull request to the merge queue Oct 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2025
@bfops bfops added this pull request to the merge queue Oct 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2025
@bfops bfops added this pull request to the merge queue Oct 21, 2025
Merged via the queue into master with commit dac57e4 Oct 21, 2025
31 checks passed
@bfops bfops deleted the bfops/discord-no-previews branch October 21, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no runtime change This change does not affect the final binaries release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants