Fixed a circular import that was not detected in the TypeScript SDK #3421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
approved these changes
Oct 17, 2025
aasoni
approved these changes
Oct 17, 2025
bfops
added a commit
that referenced
this pull request
Oct 17, 2025
…rcular import that was not detected in the TypeScript SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Alessandro ran into a stack overflow trying to use the TypeScript SDK from Remix (Node.js). We debugged it to be a circular import of
BinaryWriterdue to a barrel import. This fixes that issue.API and ABI breaking changes
This is technically an API breaking change because anyone who was importing
BinaryWriterorBinaryReaderfromspacetimedb/sdkwill now have to import it fromspacetimedborspacetimedb/lib.Expected complexity level and risk
1
Testing