Skip to content

Conversation

@joshua-spacetime
Copy link
Collaborator

@joshua-spacetime joshua-spacetime commented Oct 16, 2025

Description of Changes

This patch defines the system table schemas for views and allocates IDs for them. It does not populate these tables.

API and ABI breaking changes

None

Expected complexity level and risk

1

Testing

Tests will be added in the patch that populates these tables

@joshua-spacetime joshua-spacetime force-pushed the joshua/system-tables-for-views branch from a268e6f to f82e731 Compare October 16, 2025 22:53
Copy link
Contributor

@gefjon gefjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor request for comments, but this looks good.

@joshua-spacetime joshua-spacetime added this pull request to the merge queue Oct 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2025
@joshua-spacetime joshua-spacetime added this pull request to the merge queue Oct 17, 2025
@bfops
Copy link
Collaborator

bfops commented Oct 17, 2025

FYI the merge queue says that this will have merge conflicts 🙁

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 17, 2025
@joshua-spacetime joshua-spacetime added this pull request to the merge queue Oct 17, 2025
Merged via the queue into master with commit 542d26d Oct 17, 2025
29 of 36 checks passed
@kim kim changed the title add system tables for views [teams 2/5] client-api: Add parent parameter to publish endpoint Oct 29, 2025
@kim kim changed the title [teams 2/5] client-api: Add parent parameter to publish endpoint add system tables for views Oct 29, 2025
bfops added a commit that referenced this pull request Oct 30, 2025
bfops added a commit that referenced this pull request Oct 31, 2025
bfops added a commit that referenced this pull request Oct 31, 2025
bfops added a commit that referenced this pull request Oct 31, 2025
@joshua-spacetime joshua-spacetime deleted the joshua/system-tables-for-views branch November 19, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants