Fix clippy lints

Author: coolreader18

crates/commitlog/src/index/indexfile.rs

@@ -227,7 +227,7 @@ impl<Key: Into<u64> + From<u64>> IndexFileMut<Key> {
     }
 
     /// Obtain an iterator over the entries of the index.
-    pub fn entries(&self) -> Entries<Key> {
+    pub fn entries(&self) -> Entries<'_, Key> {
         Entries {
             mmap: &self.inner,
             pos: 0,
@@ -277,7 +277,7 @@ impl<Key: Into<u64> + From<u64>> IndexFile<Key> {
     }
 
     /// Obtain an iterator over the entries of the index.
-    pub fn entries(&self) -> Entries<Key> {
+    pub fn entries(&self) -> Entries<'_, Key> {
         self.inner.entries()
     }
 }

crates/core/src/database_logger.rs

@@ -316,7 +316,7 @@ impl SystemLogger {
         self.inner.write(LogLevel::Error, &Self::record(msg), &())
     }
 
-    fn record(message: &str) -> Record {
+    fn record(message: &str) -> Record<'_> {
         Record::injected(message)
     }
 }

crates/core/src/db/relational_db.rs

@@ -1524,7 +1524,7 @@ where
                 last_logged_percentage = percentage;
             }
         // Print _something_ even if we don't know what's still ahead.
-        } else if tx_offset % 10_000 == 0 {
+        } else if tx_offset.is_multiple_of(10_000) {
             log::info!("[{database_identity}] Loading transaction {tx_offset}");
         }
     };

crates/core/src/host/wasmtime/mod.rs

@@ -269,7 +269,7 @@ impl MemView {
 
     /// Lossily get a utf8 slice of wasm memory given a pointer and a length, converting any
     /// non-utf8 bytes to `U+FFFD REPLACEMENT CHARACTER`.
-    fn deref_str_lossy(&self, offset: WasmPtr<u8>, len: u32) -> Result<Cow<str>, MemError> {
+    fn deref_str_lossy(&self, offset: WasmPtr<u8>, len: u32) -> Result<Cow<'_, str>, MemError> {
         self.deref_slice(offset, len).map(String::from_utf8_lossy)
     }
 

crates/core/src/subscription/tx.rs

@@ -171,7 +171,7 @@ impl DeltaStore for DeltaTx<'_> {
         index_id: IndexId,
         delta: Delta,
         range: impl RangeBounds<AlgebraicValue>,
-    ) -> impl Iterator<Item = Row> {
+    ) -> impl Iterator<Item = Row<'_>> {
         fn scan_index<'a>(
             data: Option<&'a TxData>,
             indexes: &'a DeltaTableIndexes,
@@ -221,7 +221,7 @@ impl DeltaStore for DeltaTx<'_> {
         index_id: IndexId,
         delta: Delta,
         point: &AlgebraicValue,
-    ) -> impl Iterator<Item = Row> {
+    ) -> impl Iterator<Item = Row<'_>> {
         self.index_scan_range_for_delta(table_id, index_id, delta, point)
     }
 }

crates/datastore/src/locking_tx_datastore/mut_tx.rs

@@ -122,7 +122,7 @@ impl DeltaStore for MutTxId {
         _: IndexId,
         _: spacetimedb_lib::query::Delta,
         _: impl RangeBounds<AlgebraicValue>,
-    ) -> impl Iterator<Item = Row> {
+    ) -> impl Iterator<Item = Row<'_>> {
         std::iter::empty()
     }
 
@@ -134,7 +134,7 @@ impl DeltaStore for MutTxId {
         _: IndexId,
         _: spacetimedb_lib::query::Delta,
         _: &AlgebraicValue,
-    ) -> impl Iterator<Item = Row> {
+    ) -> impl Iterator<Item = Row<'_>> {
         std::iter::empty()
     }
 }

crates/execution/src/lib.rs

@@ -33,7 +33,7 @@ pub trait Datastore {
             .ok_or_else(|| anyhow!("TableId `{table_id}` does not exist"))
     }
 
-    fn table_scan(&self, table_id: TableId) -> Result<TableScanIter> {
+    fn table_scan(&self, table_id: TableId) -> Result<TableScanIter<'_>> {
         self.table(table_id)
             .map(|table| table.scan_rows(self.blob_store()))
             .ok_or_else(|| anyhow!("TableId `{table_id}` does not exist"))
@@ -44,7 +44,7 @@ pub trait Datastore {
         table_id: TableId,
         index_id: IndexId,
         key: &AlgebraicValue,
-    ) -> Result<IndexScanPointIter> {
+    ) -> Result<IndexScanPointIter<'_>> {
         self.table(table_id)
             .ok_or_else(|| anyhow!("TableId `{table_id}` does not exist"))
             .and_then(|table| {
@@ -60,7 +60,7 @@ pub trait Datastore {
         table_id: TableId,
         index_id: IndexId,
         range: &impl RangeBounds<AlgebraicValue>,
-    ) -> Result<IndexScanRangeIter> {
+    ) -> Result<IndexScanRangeIter<'_>> {
         self.table(table_id)
             .ok_or_else(|| anyhow!("TableId `{table_id}` does not exist"))
             .and_then(|table| {
@@ -93,17 +93,17 @@ pub trait DeltaStore {
         index_id: IndexId,
         delta: Delta,
         range: impl RangeBounds<AlgebraicValue>,
-    ) -> impl Iterator<Item = Row>;
+    ) -> impl Iterator<Item = Row<'_>>;
 
     fn index_scan_point_for_delta(
         &self,
         table_id: TableId,
         index_id: IndexId,
         delta: Delta,
         point: &AlgebraicValue,
-    ) -> impl Iterator<Item = Row>;
+    ) -> impl Iterator<Item = Row<'_>>;
 
-    fn delta_scan(&self, table_id: TableId, inserts: bool) -> DeltaScanIter {
+    fn delta_scan(&self, table_id: TableId, inserts: bool) -> DeltaScanIter<'_> {
         match inserts {
             true => DeltaScanIter {
                 iter: self.inserts_for_table(table_id),

crates/lib/src/db/raw_def/v9.rs

@@ -488,7 +488,7 @@ impl RawModuleDefV9Builder {
         &mut self,
         name: impl Into<RawIdentifier>,
         product_type_ref: AlgebraicTypeRef,
-    ) -> RawTableDefBuilder {
+    ) -> RawTableDefBuilder<'_> {
         let name = name.into();
         RawTableDefBuilder {
             module_def: &mut self.module,
@@ -513,7 +513,7 @@ impl RawModuleDefV9Builder {
         table_name: impl Into<RawIdentifier>,
         product_type: impl Into<spacetimedb_sats::ProductType>,
         custom_ordering: bool,
-    ) -> RawTableDefBuilder {
+    ) -> RawTableDefBuilder<'_> {
         let table_name = table_name.into();
 
         let product_type_ref = self.add_algebraic_type(
@@ -533,7 +533,7 @@ impl RawModuleDefV9Builder {
         table_name: impl Into<RawIdentifier>,
         mut product_type: spacetimedb_sats::ProductType,
         custom_ordering: bool,
-    ) -> RawTableDefBuilder {
+    ) -> RawTableDefBuilder<'_> {
         self.add_expand_product_type_for_tests(&mut 0, &mut product_type);
 
         self.build_table_with_new_type(table_name, product_type, custom_ordering)

crates/sats/src/array_value.rs

@@ -113,7 +113,7 @@ impl ArrayValue {
     }
 
     /// Returns a cloning iterator on the elements of `self` as `AlgebraicValue`s.
-    pub fn iter_cloned(&self) -> ArrayValueIterCloned {
+    pub fn iter_cloned(&self) -> ArrayValueIterCloned<'_> {
         match self {
             ArrayValue::Sum(v) => ArrayValueIterCloned::Sum(v.iter()),
             ArrayValue::Product(v) => ArrayValueIterCloned::Product(v.iter()),

crates/schema/src/def.rs

@@ -253,7 +253,7 @@ impl ModuleDef {
     pub fn reducer_arg_deserialize_seed<K: ?Sized + Hash + Equivalent<Identifier>>(
         &self,
         name: &K,
-    ) -> Option<(ReducerId, ReducerArgsDeserializeSeed)> {
+    ) -> Option<(ReducerId, ReducerArgsDeserializeSeed<'_>)> {
         let (id, reducer) = self.reducer_full(name)?;
         Some((id, ReducerArgsDeserializeSeed(self.typespace.with_type(reducer))))
     }