forked from flutter/flutter
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit d36d25f
TextEditingDelta Support for the Web (flutter#28527)
* Initial implementation of TextEditingDeltaState for the web
* Capture composing region through compositionupdate and handle cases where there is an edit that occurs before the current cursor position
* clean up unused code
* clean up rest of logs
* Make sure we initialize oldText in beforeInput
* Clean up comments
* more defaults
* Add more comments
* Move delta inferrence logic to TextEditingDeltaState
* Add new listeners to rest of strategies
* Fix existing tests
* Fix tests
* Add lastTextEditingDeltaState to test
* fix tests
* Add some preliminary tests for TextEditingDeltaState
* Send as list to framework
* Add composing region test
* Address nits
* Update tests
* Try to fix tests
* Prefer const with constant constructors
* Clean up comments
* Specify types
* fix tests
* Specify type annotations
* batchDeltas -> deltas
* Make eventData nullable so we dont compare with a 'null' string
* Make TextEditingDeltaState mutable to avoid multiple copies
* Fix analyzer
* Fix test
* Use safe browser api instead of directly accessing js_util
* remove last prefix from editingDeltaState
* Remove logs
* fix merge
* fix whitespace
* revert composing changes
* update comments
* remove trailing whitespace
* Add docs for TextEditingDeltaState
* Normalize delta naming and use a copy instead of modifying function arguments
* Update selection of delta in inferDeltaState instead of onChange
* Fix tests, previously the selection was not set in inferDeltaState, now it
is so the tests should reflect this change
* Make a copy of delta instead of modifying function arguments
* remove whitespace
* Move some logic into inferDeltaState
* whitespace
* analyzer fix
* Revert "analyzer fix"
This reverts commit 786a52810cf59ed2e06be7100314d779807863d7.
* Revert "whitespace"
This reverts commit 98fad4709b9f153e47bc56ef6a2606f99e37eee2.
* Revert "Move some logic into inferDeltaState"
This reverts commit a600e9e567a7ef78bb9bb8dd3e5c86c06076f098.
* pass _editingDeltaState instead of editingDeltaState to onChange for clarity
* Add docs for beforeinput
* Add docs for inferDeltaState
* whitespace
* Add more docs
* update docs
* update docs
* Fix for insertion of a period following a double space within old text bounds
* Fix accent insertion
* clean up comments
* Address comments for clarity aand regexp
* Make composing and selection nullable
* update docs
* whitespace
* address comments
Co-authored-by: Renzo Olivares <roliv@google.com>1 parent f55b161 commit d36d25fCopy full SHA for d36d25f
File tree
Expand file treeCollapse file tree
3 files changed
+462
-14
lines changedFilter options
- lib/web_ui
- lib/src/engine/text_editing
- test
- engine/semantics
Expand file treeCollapse file tree
3 files changed
+462
-14
lines changed
0 commit comments