Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clerk-js): Handle empty 204 responses from FAPI #5410

Merged
merged 10 commits into from
Mar 26, 2025
Merged

fix(clerk-js): Handle empty 204 responses from FAPI #5410

merged 10 commits into from
Mar 26, 2025

Conversation

anagstef
Copy link
Member

@anagstef anagstef commented Mar 21, 2025 •
edited
Loading

Description

We want to handle 204 responses from FAPI with empty body.
The response.json() throws when response has no body.
The resource fromJSON will be called with null which skips updating the resource and returns the current state.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@anagstef anagstef self-assigned this Mar 21, 2025
@vercel Vercel
Copy link

vercel bot commented Mar 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2025 11:40am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: bcbc2b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@anagstef
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @anagstef - the snapshot version command generated the following package versions:

Package Version
@clerk/agent-toolkit 0.0.12-snapshot.v20250321105238
@clerk/astro 2.4.1-snapshot.v20250321105238
@clerk/backend 1.25.4-snapshot.v20250321105238
@clerk/chrome-extension 2.2.18-snapshot.v20250321105238
@clerk/clerk-js 5.57.1-snapshot.v20250321105238
@clerk/clerk-expo 2.9.1-snapshot.v20250321105238
@clerk/express 1.3.55-snapshot.v20250321105238
@clerk/fastify 2.1.28-snapshot.v20250321105238
@clerk/nextjs 6.12.7-snapshot.v20250321105238
@clerk/nuxt 1.4.2-snapshot.v20250321105238
@clerk/react-router 1.1.7-snapshot.v20250321105238
@clerk/remix 4.5.7-snapshot.v20250321105238
@clerk/testing 1.4.29-snapshot.v20250321105238

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/agent-toolkit

npm i @clerk/agent-toolkit@0.0.12-snapshot.v20250321105238 --save-exact

@clerk/astro

npm i @clerk/astro@2.4.1-snapshot.v20250321105238 --save-exact

@clerk/backend

npm i @clerk/backend@1.25.4-snapshot.v20250321105238 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@2.2.18-snapshot.v20250321105238 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.57.1-snapshot.v20250321105238 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.9.1-snapshot.v20250321105238 --save-exact

@clerk/express

npm i @clerk/express@1.3.55-snapshot.v20250321105238 --save-exact

@clerk/fastify

npm i @clerk/fastify@2.1.28-snapshot.v20250321105238 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@6.12.7-snapshot.v20250321105238 --save-exact

@clerk/nuxt

npm i @clerk/nuxt@1.4.2-snapshot.v20250321105238 --save-exact

@clerk/react-router

npm i @clerk/react-router@1.1.7-snapshot.v20250321105238 --save-exact

@clerk/remix

npm i @clerk/remix@4.5.7-snapshot.v20250321105238 --save-exact

@clerk/testing

npm i @clerk/testing@1.4.29-snapshot.v20250321105238 --save-exact

@anagstef
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @anagstef - the snapshot version command generated the following package versions:

Package Version
@clerk/agent-toolkit 0.0.12-snapshot.v20250321141137
@clerk/astro 2.4.1-snapshot.v20250321141137
@clerk/backend 1.25.4-snapshot.v20250321141137
@clerk/chrome-extension 2.2.18-snapshot.v20250321141137
@clerk/clerk-js 5.57.1-snapshot.v20250321141137
@clerk/elements 0.23.4-snapshot.v20250321141137
@clerk/clerk-expo 2.9.1-snapshot.v20250321141137
@clerk/expo-passkeys 0.1.25-snapshot.v20250321141137
@clerk/express 1.3.55-snapshot.v20250321141137
@clerk/fastify 2.1.28-snapshot.v20250321141137
@clerk/localizations 3.13.1-snapshot.v20250321141137
@clerk/nextjs 6.12.7-snapshot.v20250321141137
@clerk/nuxt 1.4.2-snapshot.v20250321141137
@clerk/clerk-react 5.25.1-snapshot.v20250321141137
@clerk/react-router 1.1.7-snapshot.v20250321141137
@clerk/remix 4.5.7-snapshot.v20250321141137
@clerk/shared 3.1.0-snapshot.v20250321141137
@clerk/testing 1.4.29-snapshot.v20250321141137
@clerk/themes 2.2.23-snapshot.v20250321141137
@clerk/types 4.49.1-snapshot.v20250321141137
@clerk/vue 1.4.1-snapshot.v20250321141137

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/agent-toolkit

npm i @clerk/agent-toolkit@0.0.12-snapshot.v20250321141137 --save-exact

@clerk/astro

npm i @clerk/astro@2.4.1-snapshot.v20250321141137 --save-exact

@clerk/backend

npm i @clerk/backend@1.25.4-snapshot.v20250321141137 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@2.2.18-snapshot.v20250321141137 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.57.1-snapshot.v20250321141137 --save-exact

@clerk/elements

npm i @clerk/elements@0.23.4-snapshot.v20250321141137 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.9.1-snapshot.v20250321141137 --save-exact

@clerk/expo-passkeys

npm i @clerk/expo-passkeys@0.1.25-snapshot.v20250321141137 --save-exact

@clerk/express

npm i @clerk/express@1.3.55-snapshot.v20250321141137 --save-exact

@clerk/fastify

npm i @clerk/fastify@2.1.28-snapshot.v20250321141137 --save-exact

@clerk/localizations

npm i @clerk/localizations@3.13.1-snapshot.v20250321141137 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@6.12.7-snapshot.v20250321141137 --save-exact

@clerk/nuxt

npm i @clerk/nuxt@1.4.2-snapshot.v20250321141137 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.25.1-snapshot.v20250321141137 --save-exact

@clerk/react-router

npm i @clerk/react-router@1.1.7-snapshot.v20250321141137 --save-exact

@clerk/remix

npm i @clerk/remix@4.5.7-snapshot.v20250321141137 --save-exact

@clerk/shared

npm i @clerk/shared@3.1.0-snapshot.v20250321141137 --save-exact

@clerk/testing

npm i @clerk/testing@1.4.29-snapshot.v20250321141137 --save-exact

@clerk/themes

npm i @clerk/themes@2.2.23-snapshot.v20250321141137 --save-exact

@clerk/types

npm i @clerk/types@4.49.1-snapshot.v20250321141137 --save-exact

@clerk/vue

npm i @clerk/vue@1.4.1-snapshot.v20250321141137 --save-exact

@anagstef anagstef changed the title fix(clerk-js): Handle empty responses from FAPI fix(clerk-js): Handle empty 204 responses from FAPI Mar 21, 2025
@anagstef anagstef marked this pull request as ready for review March 21, 2025 17:39
@anagstef anagstef merged commit d7f13ac into main Mar 26, 2025
30 checks passed
@anagstef anagstef deleted the stefanos/hotfix-handle-empty-response branch March 26, 2025 13:17
@clerk-cookie clerk-cookie mentioned this pull request Mar 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacekradko jacekradko jacekradko approved these changes

@panteliselef panteliselef panteliselef approved these changes

@brkalow brkalow Awaiting requested review from brkalow

@nikosdouvlis nikosdouvlis Awaiting requested review from nikosdouvlis

Assignees

@anagstef anagstef

Labels
clerk-js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anagstef @clerk-cookie @jacekradko @panteliselef