fix(nextjs): Move server-only resolution to runtime
#3761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6f71552 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LauraBeatris
force-pushed
the
move-server-only-error-to-runtime
branch
from
7507e56 to
e149817
Compare
LauraBeatris
changed the title
server-only resolution to runtime server-only resolution to runtime
tmilewski
approved these changes
Jul 18, 2024
LauraBeatris
changed the title
server-only resolution to runtime server-only resolution to runtime
LauraBeatris
force-pushed
the
move-server-only-error-to-runtime
branch
from
c62df84 to
6f71552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#3758 introduces an issue where
server-onlygets resolved when importing any module from@clerk/nextjs/server. An example of that is that the error gets thrown when usinggetAuthfromgetServerSideProps.This PRs moves the
server-onlyresolution to runtime withinauthandcurrentUser.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change