Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: scaling: cleanup trap should be registered before init phase #251

Open
grahamwhaley opened this issue Oct 28, 2019 · 0 comments
Open
Labels

Comments

@grahamwhaley
Copy link

The trap cleanup command is currently done in the run() function in the scaling tests - but, by then we have already done the stats init. This leads to an issue whereby if the previous run has left the stats active in the cluster, or we fail early for any other reason (fail before run()), we end up leaving the stats in place, and never cleaning them up.

We should register the trap cleanup before we do the stats init to try and capture and clean up all errant situations.

@dklyle dklyle added the scaling label Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants