Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete test description for scaling tests. #234

Open
marcemq opened this issue Oct 22, 2019 · 2 comments
Open

Incomplete test description for scaling tests. #234

marcemq opened this issue Oct 22, 2019 · 2 comments
Labels

Comments

@marcemq
Copy link
Contributor

marcemq commented Oct 22, 2019

From code we currently have four type of scaling tests:

  • k8s_parallel.sh
  • k8s_scale_nc.sh
  • k8s_scale_rapid.sh
  • k8s_scale.sh

which have the same description for all tests when asking for test execution help:

$ ./k8s_scale.sh -h
Usage: ./scaling/k8s_scale.sh [-h] [options]
   Description:
        Launch a series of workloads and take memory metric measurements after
        each launch.
   Options:
                -h,    Help page.

Environment variables:
        Name (default)
                Description
        TEST_NAME (k8s scaling)
                Can be set to over-ride the default JSON results filename
        NUM_PODS (20)
                Number of pods to launch
        STEP (1)
                Number of pods to launch per cycle
        wait_time (30)
                Seconds to wait for pods to become ready
        delete_wait_time (600)
                Seconds to wait for all pods to be deleted
        settle_time (5)
                Seconds to wait after pods ready before taking measurements
        use_api (yes)
                specify yes or no to use the API to launch pods
        grace (30)
                specify the grace period in seconds for workload pod termination

such description is incomplete and it can lead to a confusion, they exist because they're different which needs to be reflect on each test description and the README file.

@dklyle dklyle added the scaling label Oct 22, 2019
@marcemq
Copy link
Contributor Author

marcemq commented Nov 5, 2019

The PR #262 edits the description of k8s_parallel.sh and k8s_scale.sh, so we're half way to close this issue.

@marcemq
Copy link
Contributor Author

marcemq commented Nov 22, 2019

The PR #278 edits the description of k8s_scale_rapid.sh and k8s_scale_nc.sh, once such changes get accepted we can closed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants