Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

config: Create a configuration.toml for Kata #920

Open
sboeuf opened this issue Jan 12, 2018 · 3 comments
Open

config: Create a configuration.toml for Kata #920

sboeuf opened this issue Jan 12, 2018 · 3 comments

Comments

@sboeuf
Copy link
Contributor

sboeuf commented Jan 12, 2018

We should provide an alternate configuration_kata.toml.in file in order to generate configuration_kata.toml. This would prevent from confusion if we want to test Kata and Clear on the same machine.

@jodh-intel
Copy link
Contributor

If we are careful with how we handle #921, we could set an extra make variable to be either kata or cc or something and then conditionally set CONFIG_FILE rather than the current:

CONFIG_FILE = configuration.toml

@jodh-intel
Copy link
Contributor

Hi @sboeuf - I'm now thinking it would be better to generate a single configuration.toml for a particular PROJECT_NAME (see #921). If you agree, can we close this issue (or update it to generate a configuration.toml for a kata system rather than actually create a configuration-kata.toml)?

@sboeuf
Copy link
Contributor Author

sboeuf commented Jan 16, 2018

@jodh-intel yes I agree this would make more sense, and eventually, this config file would be copied to the right directory /etc/share/defaults/kata-containers/configuration.toml when calling into make kata-install.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants