Added title info to visualization with optional show_id arg#211
Merged
sanjanag merged 5 commits intocleanlab:mainfrom Jul 17, 2023
Merged
Added title info to visualization with optional show_id arg#211sanjanag merged 5 commits intocleanlab:mainfrom
sanjanag merged 5 commits intocleanlab:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #211 +/- ##
==========================================
- Coverage 95.65% 95.38% -0.27%
==========================================
Files 16 16
Lines 944 954 +10
Branches 184 188 +4
==========================================
+ Hits 903 910 +7
- Misses 21 23 +2
- Partials 20 21 +1
|
Member
|
add screenshots |
jwmueller
reviewed
Jul 14, 2023
| raise ValueError("issue_types list is empty") | ||
| for issue_type in issue_types: | ||
| self._visualize(issue_type, num_images, cell_size) | ||
| self._visualize(issue_type, num_images, cell_size, show_id) |
Member
There was a problem hiding this comment.
try to hit this line in unit tests if not too hard
jwmueller
reviewed
Jul 14, 2023
jwmueller
approved these changes
Jul 14, 2023
Member
jwmueller
left a comment
jwmueller
left a comment
There was a problem hiding this comment.
LGTM, feel free to merge whenever.
Just had small docstring suggestion and suggest to improve codecov
Co-authored-by: Jonas Mueller <1390638+jwmueller@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Examples notebook
