Skip to content

Comments

Changed import for Imagelab#182

Merged
sanjanag merged 5 commits intocleanlab:mainfrom
sanjanag:direct-import
May 24, 2023
Merged

Changed import for Imagelab#182
sanjanag merged 5 commits intocleanlab:mainfrom
sanjanag:direct-import

Conversation

@sanjanag
Copy link
Contributor

@sanjanag sanjanag commented May 22, 2023

Now one can import like this:
from cleanvision import Imagelab

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #182 (1a13c5f) into main (e1fe8a4) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
- Coverage   94.11%   94.01%   -0.10%     
==========================================
  Files          16       16              
  Lines         883      885       +2     
  Branches      164      164              
==========================================
+ Hits          831      832       +1     
- Misses         32       33       +1     
  Partials       20       20              
Impacted Files Coverage Δ
src/cleanvision/utils/serialize.py 100.00% <ø> (ø)
src/cleanvision/__init__.py 100.00% <100.00%> (ø)
src/cleanvision/imagelab.py 88.57% <100.00%> (ø)

... and 1 file with indirect coverage changes

@sanjanag sanjanag marked this pull request as ready for review May 22, 2023 20:05
@sanjanag sanjanag linked an issue May 22, 2023 that may be closed by this pull request
@sanjanag sanjanag self-assigned this May 22, 2023
Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't forget to update our blogpost and cleanvision-examples notebook repos too.
Don't merge this PR until right before you are ready to release the next cleanvision version to avoid confusing people.

@sanjanag
Copy link
Contributor Author

There's some error in building docs, I'm fixing that

@sanjanag sanjanag force-pushed the direct-import branch 2 times, most recently from 9bca4aa to b235bdf Compare May 24, 2023 18:51
@sanjanag sanjanag merged commit c332a25 into cleanlab:main May 24, 2023
@sanjanag sanjanag deleted the direct-import branch May 24, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

import Imagelab directly from cleanvision

2 participants