Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rust-numpy for data IO #1

Closed
clbarnes opened this issue Jan 20, 2020 · 1 comment
Closed

Use rust-numpy for data IO #1

clbarnes opened this issue Jan 20, 2020 · 1 comment

Comments

@clbarnes
Copy link
Owner

Currently goes from array-like -> numpy array -> python list -> rust vec -> rust type -> rust vec -> python list -> numpy array, which is a lot of copies and changing type information; plus vec-of-vec isn't an efficient data structure (although we don't index into the top vec so maybe it's not so bad).

Blockers

Thoughts

Don't want to copy the array more than necessary, but we may need to clone it on the rust side to prevent releasing/mutating the original memory if we were to use Into.

@clbarnes
Copy link
Owner Author

Released in v0.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant