Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication backwards compatibility #10

Closed
claytondaley opened this issue Apr 20, 2015 · 3 comments
Closed

Authentication backwards compatibility #10

claytondaley opened this issue Apr 20, 2015 · 3 comments
Labels
Milestone

Comments

@claytondaley
Copy link
Owner

Legacy (v1) API endpoints do not support the access keys generated by the v2 authentication process. The Token authentication does not verify the token (yet) so it can be constructed with a v1 key. At the moment, however, a single BaseAPI instance cannot connect to both v1 and v2 resources.

Options include:

  • Forcing the user to make separate v1 and v2 objects (current workaround)
  • Dedicated v1 and v2 authentication providers
    • Both would need to be optional in the constructor which is NOT desirable
  • A Chain of Responsibility (with some kind of NotSupportedError)
@claytondaley claytondaley added this to the 2.0 milestone Apr 20, 2015
@claytondaley
Copy link
Owner Author

Asked FutureSimple if there is an easy way to connect to both and will await their response.

@claytondaley
Copy link
Owner Author

FutureSimple confirmed that you cannot access APIv1 endpoints using an OAuth2 token. Will be necessary to maintain separate v1 and v2 tokens presently.

@claytondaley
Copy link
Owner Author

Moved authentication modules into the v1 and v2 folders with custom logic. For now, the Base client will be dedicated to whichever type of authentication you feed it. #19 is the successor to this issue addressing the gaps in this resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant