improved handleStart perf #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved .sorting to a local property instead of a this.setState call could make an immutable scoped var or something, but this works for now
jakedowns
changed the title
|
I have an issue with the current sortable HOC that I believe would be fixed by this, is there anything stopping this from being merged? |
redking
added a commit
to DataDog/react-sortable-hoc
that referenced
this pull request
Oct 23, 2018
…-hoc - remove state changes to improve handleStart perf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small tweak: moved .sorting to a local property instead of a this.setState call
could make an immutable scoped var or something, but this works for now.
I was experiencing some lag on .handleStart due to the setState call on the container
(~30ms with 57 items / ~165ms with 351 items)
by moving this field to a class-level property, rather than Component.state, handleStart now executes in ~1-5ms for me (even with 350 items)