Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External subtitle support #55

Open
katsar0v opened this issue Feb 4, 2019 · 6 comments
Open

External subtitle support #55

katsar0v opened this issue Feb 4, 2019 · 6 comments

Comments

@katsar0v
Copy link

katsar0v commented Feb 4, 2019

Is there any support for external subtitle files?

@katsar0v
Copy link
Author

katsar0v commented Feb 6, 2019

Am not sure what this means:

it's still only compatible with html5_video playback

I am using hls streams.

@leandromoreira
Copy link
Member

@katsar0v hls stream over shaka? but anyway html5_video is a super class used by hls and dash playbacks.

@leandromoreira
Copy link
Member

This PR added cc support https://github.com/clappr/dash-shaka-playback/pull/34/files but it might be buggy the demo https://jsfiddle.net/m8ndduLo/69/ used to work

@joaopaulovieira
Copy link
Member

@leandromoreira, It's the issue resolved by the PR you mentioned?

@leandromoreira
Copy link
Member

@joaopaulovieira don't know =(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants