Skip to content

Commit 4d086df

Browse files
authored
Make chooseAsset more precise: search for clangd-<platform>. (#7)
Previously we just searched for <platform> which matched our indexer releases, oops!
1 parent c08666d commit 4d086df

File tree

2 files changed

+36
-1
lines changed

2 files changed

+36
-1
lines changed

src/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,8 @@ export async function chooseAsset(release: Github.Release):
194194
// Mac distribution contains a fat binary working on both x64
195195
// and arm64s.
196196
(os.arch() == 'arm64' && variant == 'mac'))) {
197-
const asset = release.assets.find(a => a.name.indexOf(variant) >= 0);
197+
const substr = 'clangd-' + variant;
198+
const asset = release.assets.find(a => a.name.indexOf(substr) >= 0);
198199
if (asset)
199200
return asset;
200201
}

test/assets/release.json

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,40 @@
3333
"created_at": "2020-02-20T12:44:25Z",
3434
"published_at": "2020-03-10T09:42:12Z",
3535
"assets": [
36+
{
37+
"url": "http://api.github.com/repos/clangd/clangd/releases/assets/18600444",
38+
"id": 18600444,
39+
"node_id": "MDEyOlJlbGVhc2VBc3NldDE4NjAwNDQ0",
40+
"name": "clangd-indexing-tools-linux-10.zip",
41+
"label": "",
42+
"uploader": {
43+
"login": "clangd-build",
44+
"id": 60678011,
45+
"node_id": "MDQ6VXNlcjYwNjc4MDEx",
46+
"avatar_url": "https://avatars2.githubusercontent.com/u/60678011?v=4",
47+
"gravatar_id": "",
48+
"url": "https://api.github.com/users/clangd-build",
49+
"html_url": "https://github.com/clangd-build",
50+
"followers_url": "https://api.github.com/users/clangd-build/followers",
51+
"following_url": "https://api.github.com/users/clangd-build/following{/other_user}",
52+
"gists_url": "https://api.github.com/users/clangd-build/gists{/gist_id}",
53+
"starred_url": "https://api.github.com/users/clangd-build/starred{/owner}{/repo}",
54+
"subscriptions_url": "https://api.github.com/users/clangd-build/subscriptions",
55+
"organizations_url": "https://api.github.com/users/clangd-build/orgs",
56+
"repos_url": "https://api.github.com/users/clangd-build/repos",
57+
"events_url": "https://api.github.com/users/clangd-build/events{/privacy}",
58+
"received_events_url": "https://api.github.com/users/clangd-build/received_events",
59+
"type": "User",
60+
"site_admin": false
61+
},
62+
"content_type": "application/zip",
63+
"state": "uploaded",
64+
"size": 46545010,
65+
"download_count": 615,
66+
"created_at": "2020-03-10T09:22:40Z",
67+
"updated_at": "2020-03-10T09:22:41Z",
68+
"browser_download_url": "http://localhost:9999/does-not-exist.zip"
69+
},
3670
{
3771
"url": "http://api.github.com/repos/clangd/clangd/releases/assets/18600444",
3872
"id": 18600444,

0 commit comments

Comments
 (0)