Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO add Cpython 2.7 testing for Ubuntu GitHub Workflow Actions #62

Open
clach04 opened this issue Jul 1, 2023 · 3 comments
Open

TODO add Cpython 2.7 testing for Ubuntu GitHub Workflow Actions #62

clach04 opened this issue Jul 1, 2023 · 3 comments

Comments

@clach04
Copy link
Owner

clach04 commented Jul 1, 2023

For background see #59

Idea, adopt change arthurdejong/python-pskc@9ce2424 - viz. add a new ubuntu CPython 2.7 job, and leave existing matrix alone (i.e. no conditional, so means some duplication):

jobs:
  base_py27:
    runs-on: ubuntu-20.04
    container:
      image: python:2.7.18-buster
    strategy:
      fail-fast: false
      matrix:
        python-version: [2.7]
        flavour: [signxml, legacy, legacy-defusedxml, lxml, lxml-defusedxml]
    steps:
      - uses: actions/checkout@v3
      - name: Install dependencies
        run: python -m pip install --upgrade pip virtualenv tox
      - name: Install development libraries
        if: "${{ startsWith(matrix.python-version, 'pypy') }}"
        run: sudo apt-get update && sudo apt-get install -y libxml2-dev libxslt-dev
      - name: Run tox
        run: tox -e "$(echo py${{ matrix.python-version }}-${{ matrix.flavour }} | sed -e 's/[.]//g;s/pypypy/pypy/')" --skip-missing-interpreters false
  base:
    runs-on: ubuntu-20.04
    strategy:
      fail-fast: false
      matrix:
        #python-version: [2.7, 3.5, 3.6, 3.7, 3.8, 3.9, '3.10', 3.11, pypy2.7, pypy3.8, pypy3.9]  # REMOVED
        python-version: [3.5, 3.6, 3.7, 3.8, 3.9, '3.10', 3.11, pypy2.7, pypy3.8, pypy3.9]
@clach04
Copy link
Owner Author

clach04 commented Jul 22, 2023

Also check out https://github.com/coatl-dev/docker-six

@clach04 clach04 changed the title TODO add Cpython 2,7 testing for Ubuntu GitHub Workflow Actions TODO add Cpython 2.7 testing for Ubuntu GitHub Workflow Actions Sep 9, 2023
@clach04
Copy link
Owner Author

clach04 commented Jan 20, 2024

https://github.com/dateutil/dateutil/blob/0586f4afa26fc6799128d98d4f97a49c7d6ab314/.github/workflows/validate.yml#L39-L56
...
include:
- python-version: "2.7"
os: "ubuntu-20.04"
- python-version: "3.5"
os: "ubuntu-20.04"
- python-version: "3.6"
os: "ubuntu-20.04"
runs-on: ${{ matrix.os }}
env:
TOXENV: py
steps:
- uses: actions/checkout@v3
- if: ${{ matrix.python-version == '2.7' }}
run: |
sudo apt-get install python-is-python2
curl -sSL https://bootstrap.pypa.io/pip/2.7/get-pip.py -o get-pip.py
python get-pip.py
name: Set up Python ${{ matrix.python-version }} on ${{ matrix.os }}
- if: ${{ matrix.python-version != '2.7' }}
name: Set up Python ${{ matrix.python-version }} on ${{ matrix.os }}
uses: actions/setup-python@v3
with:
python-version: ${{ matrix.python-version }}
...

@clach04
Copy link
Owner Author

clach04 commented Jan 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant