Morph snake smoothing #296
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've added
superior_inferiorandinferior_superiorfunctions as used in the smoothing process in scikit-image morphsnakes.There's one issue with the tests for both 2D and 3D:
If there are pixels adjacent to the image boundaries, the scikit-image implementation and my implementation differ. I think this is due to the opencl kernel taking pixels outside the image boundary as 1, whereas it should be 0.
You can see this in the final example in the notebook.
Is there an easy way to fix this problem in the opencl kernel?
Thanks,
Graham