Add ability to install man pages via make install (ioncoincore#27)

* Add support for out-of-tree builds in gen-manpages.sh

This adds support for setting the environment variable `BUILDDIR`
to point to executables that are outside the source directory.

E.g. to invoke the tool when the build is in $PWD/build:

```bash
BUILDDIR=$PWD/build contrib/devtools/gen-manpages.sh
```

* Add autogenerated manpages for 3.0.4

* Add ability to install man pages via `make install`

Author: MitchellCash

Makefile.am

@@ -6,6 +6,9 @@
 
 ACLOCAL_AMFLAGS = -I build-aux/m4
 SUBDIRS = src
+if ENABLE_MAN
+SUBDIRS += doc/man
+endif
 .PHONY: deploy FORCE
 
 export PYTHONPATH
@@ -227,5 +230,7 @@ CLEANFILES = $(OSX_DMG) $(BITCOIN_WIN_INSTALLER)
 
 .INTERMEDIATE: $(COVERAGE_INFO)
 
+DISTCHECK_CONFIGURE_FLAGS = --enable-man
+
 clean-local:
 	rm -rf test_ion.coverage/ total.coverage/ $(OSX_APP)

configure.ac

@@ -179,6 +179,12 @@ AC_ARG_WITH([system-univalue],
 
 AC_ARG_WITH([protoc-bindir],[AS_HELP_STRING([--with-protoc-bindir=BIN_DIR],[specify protoc bin path])], [protoc_bin_path=$withval], [])
 
+AC_ARG_ENABLE(man,
+    [AS_HELP_STRING([--disable-man],
+                    [do not install man pages (default is to install)])],,
+    enable_man=yes)
+AM_CONDITIONAL(ENABLE_MAN, test "$enable_man" != no)
+
 # Enable debug
 AC_ARG_ENABLE([debug],
     [AS_HELP_STRING([--enable-debug],
@@ -1141,7 +1147,7 @@ AC_SUBST(EVENT_PTHREADS_LIBS)
 AC_SUBST(ZMQ_LIBS)
 AC_SUBST(PROTOBUF_LIBS)
 AC_SUBST(QR_LIBS)
-AC_CONFIG_FILES([Makefile src/Makefile share/setup.nsi share/qt/Info.plist src/test/buildenv.py])
+AC_CONFIG_FILES([Makefile src/Makefile doc/man/Makefile share/setup.nsi share/qt/Info.plist src/test/buildenv.py])
 AC_CONFIG_FILES([qa/pull-tester/run-bitcoind-for-test.sh],[chmod +x qa/pull-tester/run-bitcoind-for-test.sh])
 AC_CONFIG_FILES([qa/pull-tester/tests-config.sh],[chmod +x qa/pull-tester/tests-config.sh])
 AC_CONFIG_FILES([contrib/devtools/split-debug.sh],[chmod +x contrib/devtools/split-debug.sh])

contrib/devtools/README.md

@@ -1,5 +1,5 @@
 Contents
-===========
+========
 This directory contains tools for developers working on this repository.
 
 check-doc.py
@@ -8,6 +8,20 @@ check-doc.py
 Check if all command line args are documented. The return value indicates the
 number of undocumented args.
 
+gen-manpages.sh
+===============
+
+A small script to automatically create manpages in ../../doc/man by running the release binaries with the -help option.
+This requires help2man which can be found at: https://www.gnu.org/software/help2man/
+
+With in-tree builds this tool can be run from any directory within the
+repostitory. To use this tool with out-of-tree builds set `BUILDDIR`. For
+example:
+
+```bash
+BUILDDIR=$PWD/build contrib/devtools/gen-manpages.sh
+```
+
 github-merge.py
 ===============
 

contrib/devtools/gen-manpages.sh

@@ -1,18 +1,20 @@
 #!/bin/bash
 
 TOPDIR=${TOPDIR:-$(git rev-parse --show-toplevel)}
-SRCDIR=${SRCDIR:-$TOPDIR/src}
+BUILDDIR=${BUILDDIR:-$TOPDIR}
+
+BINDIR=${BINDIR:-$BUILDDIR/src}
 MANDIR=${MANDIR:-$TOPDIR/doc/man}
 
-IOND=${IOND:-$SRCDIR/iond}
-IONCLI=${IONCLI:-$SRCDIR/ion-cli}
-IONTX=${IONTX:-$SRCDIR/ion-tx}
-IONQT=${IONQT:-$SRCDIR/qt/ion-qt}
+IOND=${IOND:-$BINDIR/iond}
+IONCLI=${IONCLI:-$BINDIR/ion-cli}
+IONTX=${IONTX:-$BINDIR/ion-tx}
+IONQT=${IONQT:-$BINDIR/qt/ion-qt}
 
 [ ! -x $IOND ] && echo "$IOND not found or not executable." && exit 1
 
 # The autodetected version git tag can screw up manpage output a little bit
-BTCVER=($($IONCLI --version | head -n1 | awk -F'[ -]' '{ print $6, $7 }'))
+IONVER=($($IONCLI --version | head -n1 | awk -F'[ -]' '{ print $6, $7 }'))
 
 # Create a footer file with copyright content.
 # This gets autodetected fine for iond if --version-string is not set,
@@ -22,8 +24,8 @@ $IOND --version | sed -n '1!p' >> footer.h2m
 
 for cmd in $IOND $IONCLI $IONTX $IONQT; do
   cmdname="${cmd##*/}"
-  help2man -N --version-string=${BTCVER[0]} --include=footer.h2m -o ${MANDIR}/${cmdname}.1 ${cmd}
-  sed -i "s/\\\-${BTCVER[1]}//g" ${MANDIR}/${cmdname}.1
+  help2man -N --version-string=${IONVER[0]} --include=footer.h2m -o ${MANDIR}/${cmdname}.1 ${cmd}
+  sed -i "s/\\\-${IONVER[1]}//g" ${MANDIR}/${cmdname}.1
 done
 
 rm -f footer.h2m

doc/man/ion-cli.1

@@ -1,17 +1,19 @@
-.\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.47.10.
-.TH ION-CLI "1" "June 2019" "ion-cli v5.0.99.0" "User Commands"
+.\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.47.6.
+.TH ION-CLI "1" "April 2018" "ion-cli v3.0.4.0" "User Commands"
 .SH NAME
-ion-cli \- manual page for ion-cli v5.0.99.0
+ion-cli \- manual page for ion-cli v3.0.4.0
 .SH DESCRIPTION
-Ion Core RPC client version v5.0.99.0
+Ion Core RPC client version v3.0.4.0\-CEVAP
 .SS "Usage:"
 .TP
 ion\-cli [options] <command> [params]
 Send command to Ion Core
-.IP
-ion\-cli [options] \fB\-named\fR <command> [name=value] ... Send command to Ion Core (with named arguments)
-ion\-cli [options] help                List commands
-ion\-cli [options] help <command>      Get help for a command
+.TP
+ion\-cli [options] help
+List commands
+.TP
+ion\-cli [options] help <command>
+Get help for a command
 .SH OPTIONS
 .HP
 \-?
@@ -26,41 +28,23 @@ Specify configuration file (default: ioncoin.conf)
 .IP
 Specify data directory
 .HP
-\fB\-getinfo\fR
-.IP
-Get general information from the remote server. Note that unlike
-server\-side RPC calls, the results of \fB\-getinfo\fR is the result of
-multiple non\-atomic requests. Some entries in the result may
-represent results from different states (e.g. wallet balance may
-be as of a different block from the chain state reported)
-.PP
-Chain selection options:
-.HP
 \fB\-testnet\fR
 .IP
-Use the test chain
-.HP
-\fB\-devnet=\fR<name>
-.IP
-Use devnet chain with provided name
+Use the test network
 .HP
 \fB\-regtest\fR
 .IP
 Enter regression test mode, which uses a special chain in which blocks
-can be solved instantly. This is intended for regression testing
-tools and app development.
-.HP
-\fB\-named\fR
-.IP
-Pass named instead of positional arguments (default: false)
+can be solved instantly. This is intended for regression testing tools
+and app development.
 .HP
 \fB\-rpcconnect=\fR<ip>
 .IP
 Send commands to node running on <ip> (default: 127.0.0.1)
 .HP
 \fB\-rpcport=\fR<port>
 .IP
-Connect to JSON\-RPC on <port> (default: 12705 or testnet: 27171)
+Connect to JSON\-RPC on <port> (default: 51473 or testnet: 51475)
 .HP
 \fB\-rpcwait\fR
 .IP
@@ -76,40 +60,21 @@ Password for JSON\-RPC connections
 .HP
 \fB\-rpcclienttimeout=\fR<n>
 .IP
-Timeout in seconds during HTTP requests, or 0 for no timeout. (default:
-900)
-.HP
-\fB\-stdinrpcpass\fR
-.TP
-Read RPC password from standard input as a single line.
-When combined
-.IP
-with \fB\-stdin\fR, the first line from standard input is used for the
-RPC password.
-.HP
-\fB\-stdin\fR
-.IP
-Read extra arguments from standard input, one per line until EOF/Ctrl\-D
-(recommended for sensitive information such as passphrases).
-When combined with \fB\-stdinrpcpass\fR, the first line from standard
-input is used for the RPC password.
-.HP
-\fB\-rpcwallet=\fR<walletname>
-.IP
-Send RPC for non\-default wallet on RPC server (needs to exactly match
-corresponding \fB\-wallet\fR option passed to dashd)
+Timeout during HTTP requests (default: 900)
 .SH COPYRIGHT
-Copyright (C) 2014-2020 The Dash Core developers
-Copyright (C) 2009-2020 The Bitcoin Core developers
+Copyright (C) 2009-2018 The Bitcoin Core Developers
+
+Copyright (C) 2014-2018 The Dash Core Developers
 
-Please contribute if you find Ion Core useful. Visit <https://ionomy.com> for
-further information about the software.
-The source code is available from <https://bitbucket.org/ioncoin/ion>.
+Copyright (C) 2015-2018 The PIVX Core Developers
+
+Copyright (C) 2018 The Ion Core Developers
 
 This is experimental software.
+
 Distributed under the MIT software license, see the accompanying file COPYING
-or <https://opensource.org/licenses/MIT>
+or <http://www.opensource.org/licenses/mit-license.php>.
 
 This product includes software developed by the OpenSSL Project for use in the
-OpenSSL Toolkit <https://www.openssl.org> and cryptographic software written by
-Eric Young and UPnP software written by Thomas Bernard.
+OpenSSL Toolkit <https://www.openssl.org/> and cryptographic software written
+by Eric Young and UPnP software written by Thomas Bernard.