Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table caption toolbar button #9263

Merged
merged 18 commits into from
Apr 22, 2021
Merged

Conversation

maxbarnas
Copy link
Contributor

@maxbarnas maxbarnas commented Mar 17, 2021

Suggested merge commit message (convention)

Feature (table): Added toolbar buttons for table captions. Closes #9104. Closes #9086. Closes #9304. Closes #9087. Closes #9088. Closes #9085.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@maxbarnas maxbarnas force-pushed the i/9104-caption-toolbar branch from fc99e6d to ea274dd Compare March 18, 2021 15:37
@maxbarnas maxbarnas force-pushed the i/9104-caption-toolbar branch from b5421cc to cd4e637 Compare March 23, 2021 14:34
@maxbarnas maxbarnas changed the base branch from master to i/3204-table-caption March 23, 2021 14:35
@maxbarnas maxbarnas marked this pull request as ready for review March 30, 2021 08:44
@maxbarnas maxbarnas changed the base branch from i/3204-table-caption to i/9105-table-algorithms March 31, 2021 12:26
Copy link
Contributor

@niegowski niegowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented below. Wasn't checking tests.

packages/ckeditor5-table/src/commands/insertrowcommand.js Outdated Show resolved Hide resolved
packages/ckeditor5-table/src/tablecaption/utils.js Outdated Show resolved Hide resolved
packages/ckeditor5-table/src/tablecaption/utils.js Outdated Show resolved Hide resolved
packages/ckeditor5-table/src/tablecaption/utils.js Outdated Show resolved Hide resolved
packages/ckeditor5-widget/theme/widget.css Outdated Show resolved Hide resolved
tests/manual/all-features.js Outdated Show resolved Hide resolved
packages/ckeditor5-table/src/utils/ui/widget.js Outdated Show resolved Hide resolved
@maxbarnas maxbarnas force-pushed the i/9104-caption-toolbar branch from 7ce45f2 to 2d7fe6d Compare April 16, 2021 09:37
@maxbarnas maxbarnas requested a review from niegowski April 19, 2021 14:33
packages/ckeditor5-table/src/tablecaption/utils.js Outdated Show resolved Hide resolved
tests/manual/all-features-dll.js Outdated Show resolved Hide resolved
packages/ckeditor5-table/tests/manual/tablecaption.js Outdated Show resolved Hide resolved
packages/ckeditor5-table/tests/manual/tablecaption.md Outdated Show resolved Hide resolved
packages/ckeditor5-table/tests/manual/tablecaption.md Outdated Show resolved Hide resolved
packages/ckeditor5-table/tests/tablecaption/utils.js Outdated Show resolved Hide resolved
@maxbarnas maxbarnas requested a review from niegowski April 22, 2021 08:25
Copy link
Contributor

@niegowski niegowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented.

Base automatically changed from i/9105-table-algorithms to i/3204-table-caption April 22, 2021 11:38
Copy link
Contributor

@niegowski niegowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add "installation" instructions for the feature guide (similar to https://ckeditor.com/docs/ckeditor5/latest/features/table.html#table-and-cell-styling-tools-2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants