Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not support resource with FTP URL-s #188

Open
Chealer opened this issue Apr 24, 2020 · 0 comments · May be fixed by #208
Open

Does not support resource with FTP URL-s #188

Chealer opened this issue Apr 24, 2020 · 0 comments · May be fixed by #208

Comments

@Chealer
Copy link

Chealer commented Apr 24, 2020

Disclaimer: I did not verify this issue (I assume a change equivalent to one made for pip had a result equivalent to the one for pip).

DataPusher 0.0.6 supported loading resources over FTP. However, this seems to be no longer the case starting from 0.0.13, after commit 4610197, which stopped DataPusher from using urllib2 to use the "Requests: HTTP for Humans" library, which - unsurprisingly - only supports HTTP, as it is based on urllib3, which - despite its name - does not support FTP like urllib2 did.

I'm filing this to document the change but also so that the code can be cleaned up. The error message for unsupported schemes ("Only http, https, and ftp resources may be fetched.") has not changed and suggests that FTP resources are still supported.

Note that DataPusher's alternative xloader does not support FTP any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant