Clarify that entity_table is always civicrm_participant

mattwire · mattwire · commit e94eaa8603f6 · 2025-02-26T17:33:49.000Z
diff --git a/CRM/Event/Form/Registration/Confirm.php b/CRM/Event/Form/Registration/Confirm.php
@@ -662,7 +662,6 @@ public function postProcess() {
         $allParticipantIds = array_merge([$registerByID], $this->_additionalParticipantIds);
       }
 
-      $entityTable = 'civicrm_participant';
       $totalTaxAmount = 0;
       foreach ($this->_lineItem as $key => $value) {
         if ($value == 'skip') {
@@ -671,10 +670,10 @@ public function postProcess() {
         if ($entityId = $allParticipantIds[$key] ?? NULL) {
           // do cleanup line  items if participant re-walking wizard.
           if ($this->_allowConfirmation) {
-            CRM_Price_BAO_LineItem::deleteLineItems($entityId, $entityTable);
+            CRM_Price_BAO_LineItem::deleteLineItems($entityId, 'civicrm_participant');
           }
           $lineItem[$this->_priceSetId] = $value;
-          CRM_Price_BAO_LineItem::processPriceSet($entityId, $lineItem, $contribution, $entityTable);
+          CRM_Price_BAO_LineItem::processPriceSet($entityId, $lineItem, $contribution, 'civicrm_participant');
         }
         if (\Civi::settings()->get('invoicing')) {
           foreach ($value as $line) {

Original file line number	Diff line number	Diff line change
`@@ -662,7 +662,6 @@ public function postProcess() {`
`662`	`662`	`$allParticipantIds = array_merge([$registerByID], $this->_additionalParticipantIds);`
`663`	`663`	`}`
`664`	`664`
`665`		`- $entityTable = 'civicrm_participant';`
`666`	`665`	`$totalTaxAmount = 0;`
`667`	`666`	`foreach ($this->_lineItem as $key => $value) {`
`668`	`667`	`if ($value == 'skip') {`
`@@ -671,10 +670,10 @@ public function postProcess() {`
`671`	`670`	`if ($entityId = $allParticipantIds[$key] ?? NULL) {`
`672`	`671`	`// do cleanup line items if participant re-walking wizard.`
`673`	`672`	`if ($this->_allowConfirmation) {`
`674`		`- CRM_Price_BAO_LineItem::deleteLineItems($entityId, $entityTable);`
	`673`	`+ CRM_Price_BAO_LineItem::deleteLineItems($entityId, 'civicrm_participant');`
`675`	`674`	`}`
`676`	`675`	`$lineItem[$this->_priceSetId] = $value;`
`677`		`- CRM_Price_BAO_LineItem::processPriceSet($entityId, $lineItem, $contribution, $entityTable);`
	`676`	`+ CRM_Price_BAO_LineItem::processPriceSet($entityId, $lineItem, $contribution, 'civicrm_participant');`
`678`	`677`	`}`
`679`	`678`	`if (\Civi::settings()->get('invoicing')) {`
`680`	`679`	`foreach ($value as $line) {`