Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor subscribe_xpaths into base Client #48

Merged
merged 8 commits into from
Apr 16, 2020
Merged

Refactor subscribe_xpaths into base Client #48

merged 8 commits into from
Apr 16, 2020

Conversation

remingtonc
Copy link
Contributor

@remingtonc remingtonc commented Apr 15, 2020 •
edited
Loading

subscribe_xpaths is a common function across every OS and thus can be brought in to Client. This also enables usage by non-wrapper classes for validation of other OSes. Resolves #47

Side effects:

  • Better certificate generation logic across IOS XE, IOS XR, and NX-OS.
  • Add version to CLI output.
  • Add some more CLI options in subscribe RPC.

@remingtonc remingtonc added enhancement New feature or request refactor labels Apr 15, 2020
@remingtonc remingtonc self-assigned this Apr 15, 2020
@remingtonc remingtonc requested review from skkumaravel and removed request for skkumaravel April 15, 2020 22:00
@remingtonc remingtonc requested review from a team, brh55 and anushramsurat1 and removed request for skkumaravel and a team April 15, 2020 22:52
@remingtonc remingtonc merged commit de478bf into master Apr 16, 2020
@remingtonc remingtonc deleted the subscribe-xpaths-refactor branch April 16, 2020 23:03
This was referenced Apr 17, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brh55 brh55 Awaiting requested review from brh55

@anushramsurat1 anushramsurat1 Awaiting requested review from anushramsurat1

Assignees

@remingtonc remingtonc

Labels
enhancement New feature or request refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor subscribe_xpaths into base Client
1 participant
@remingtonc