Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CodeQL scanning for Python. #55

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Enable CodeQL scanning for Python. #55

merged 1 commit into from
Oct 9, 2020

Conversation

felddy
Copy link
Member

@felddy felddy commented Oct 8, 2020

🗣 Description

Enables code scanning and alerts.
CodeQL scanning does not make PRs.

Once enabled, scan results can be found under the repository's Security Tab.
Scan alert counts are displayed similarly to issue and PR counts.

💭 Motivation and Context

  • The more eyes 👀 we have on our code base the better.
  • Implementing this as a workflow affords us much greater control of the tool than we had on LGTM.

See: https://securitylab.github.com/tools/codeql
See: https://www.infoworld.com/article/3453742/github-makes-codeql-free-for-research-and-open-source.html

CodeQL, a semantic code analysis engine and query tool for finding security vulnerabilities across a codebase, has been made available for free by GitHub for anyone to use in research or to analyze open source code.

CodeQL queries code as if it were data. Developers can use CodeQL to write a query that finds all variants of a vulnerability, and then share that query with other developers. For example, a developer could create a query that mimics a bug class for cross-site scripting, then use that query to find any bug class. CodeQL also can be used to find zero days, variants of critical vulnerabilities, and defects such as buffer overflows or SQL injection issues.

CodeQL was developed several years ago by Semmle, which was acquired by GitHub in September 2019. Prior to making CodeQL available for free for open source code, Semmle provided it as a commercially available service. It is still available under a commercial license for private code repositories.

🧪 Testing

📷 Screenshots (if appropriate)

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Contributor

@hillaryj hillaryj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧨

@felddy felddy merged commit 62b3de6 into develop Oct 9, 2020
@felddy felddy deleted the improvement/codeql branch October 9, 2020 14:13
cisagovbot pushed a commit that referenced this pull request Oct 22, 2020
Change repo for the prettier pre-commit hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants