Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/codeowners #28

Merged
merged 4 commits into from
Nov 18, 2019
Merged

Improvement/codeowners #28

merged 4 commits into from
Nov 18, 2019

Conversation

felddy
Copy link
Member

@felddy felddy commented Nov 18, 2019

🗣 Description

Add CODEOWNERS file to the repository.
See: https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners

💭 Motivation and Context

Make it easier for maintainers and other contributors to requests PR reviews from the proper people.

🧪 Testing

CI tests as well as annoying the team with test PRs.

📷 Screenshots (if appropriate)

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@felddy felddy self-assigned this Nov 18, 2019
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

@felddy felddy merged commit ba0827c into develop Nov 18, 2019
@felddy felddy deleted the improvement/codeowners branch November 18, 2019 18:04
mcdonnnj added a commit that referenced this pull request Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants