ORE Operators and Sorting #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobyhede
commented
Jan 30, 2025
coderdan
reviewed
Feb 10, 2025
tobyhede
force-pushed
the
operator-please
branch
from
1f0f791 to
542df82
Compare
coderdan
reviewed
Feb 18, 2025
coderdan
reviewed
Feb 18, 2025
coderdan
reviewed
Feb 18, 2025
coderdan
approved these changes
Feb 18, 2025
tobyhede
force-pushed
the
operator-please
branch
from
5bcfa35 to
dd69d98
Compare
CDThomas
added a commit
that referenced
this pull request
Feb 25, 2025
This change reverts this repo back to 01dcc24. The changes reverted include commits from: - #86 - #87 We mostly want to revert the changes in #86 (since they aren't working as intended with Proxy), but #87 is also included since it's more recent (and also includes some ORE-related changes that would be tedious to untangle). Since there aren't many changes after #86, the most pragmatic option is to revert to the last known-good state and redo the install/uninstall changes by hand on top of that. Commands used to revert: ``` git reset --hard 01dcc24 git reset --soft ed460fc ``` This change doesn't use `git revert` because there were > 20 commits to revert and merge commits also don't play well with `git revert`.
CDThomas
added a commit
that referenced
this pull request
Feb 25, 2025
This change updates `cs_ore_64_8_v1` to parse ORE indexes (the `'o'` field) as JSON arrays of hex-encoded strings (instead of casting from the Postgres text format). The corresponding change for encoding ORE indexes as JSON arrays of hex-encoded stings has already been merged in Proxy. This is similar to some of the changes in #86, but we're parsing into the composite types for ORE indexes instead of into a plain `bytea[]`. Parsing into the composite type allows for ordering with an operator class on the output from `cs_ore_64_8_v1`.
CDThomas
added a commit
that referenced
this pull request
Feb 25, 2025
This change updates `cs_ore_64_8_v1` to parse ORE indexes (the `'o'` field) as JSON arrays of hex-encoded strings (instead of casting from the Postgres text format). The corresponding change for encoding ORE indexes as JSON arrays of hex-encoded stings has already been merged in Proxy. This is similar to some of the changes in #86, but we're parsing into the composite types for ORE indexes instead of into a plain `bytea[]`. Parsing into the composite type allows for ordering with an operator class on the output from `cs_ore_64_8_v1`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make ORDER by work for
cs_encrypted_v1by encoding in the EQLjsonas an array rather than the PostgreSQL Ore Types.Example ORE encoding
Requires a corresponding change in the proxy to encode the ore index value as an array:
cipherstash/proxy#110
Current status: ORE works here, but does not work via proxy and I am not sure why.