Skip to content

Cip 874 jupyter notebook updates #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 30, 2024
Merged

Conversation

yujiyokoo
Copy link
Contributor

@yujiyokoo yujiyokoo commented Oct 25, 2024

This PR includes:

  • Making the notebook run cross-platform with Windows testing
  • Removing unnecessary steps
  • Adding more information
  • Making code more robust

@yujiyokoo yujiyokoo force-pushed the cip-874-jupyter-notebook-updates branch from 4553c24 to 68e13a6 Compare October 28, 2024 08:26
@yujiyokoo yujiyokoo force-pushed the cip-874-jupyter-notebook-updates branch from 3306b03 to b399bf3 Compare October 29, 2024 07:13
@yujiyokoo yujiyokoo force-pushed the cip-874-jupyter-notebook-updates branch from b3bc16f to b54514e Compare October 29, 2024 08:16
@yujiyokoo yujiyokoo force-pushed the cip-874-jupyter-notebook-updates branch from c079ea1 to 992bde2 Compare October 30, 2024 09:07
@yujiyokoo yujiyokoo marked this pull request as ready for review October 30, 2024 09:07
Copy link
Contributor

@auxesis auxesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love your work @yujiyokoo.

I haven't run through this locally end to end, but let me know if you think I should before you merge this.

"```\n",
"txt = CsText(\"hell, world\", \"examples\", \"encrypted_utf8_str\")\n",
"txt = CsText(\"hello, world\", \"examples\", \"encrypted_utf8_str\")\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@yujiyokoo yujiyokoo merged commit 7e8b0d9 into main Oct 30, 2024
@yujiyokoo yujiyokoo deleted the cip-874-jupyter-notebook-updates branch October 30, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants