Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move "octal" function from string module to number module #913

Closed
cieslarmichal opened this issue Sep 11, 2024 · 2 comments · Fixed by #922
Closed

move "octal" function from string module to number module #913

cieslarmichal opened this issue Sep 11, 2024 · 2 comments · Fixed by #922
Labels
good first issue Good for newcomers

Comments

@cieslarmichal
Copy link
Owner

No description provided.

@cieslarmichal cieslarmichal added the good first issue Good for newcomers label Sep 11, 2024
@cieslarmichal cieslarmichal changed the title move octal function from string module to number module move "octal" function from string module to number module Sep 17, 2024
@gagankonana gagankonana mentioned this issue Sep 23, 2024
Merged
@gagankonana
Copy link
Contributor

Hi @cieslarmichal, had a quick question, there are two "octal" functions in the string module, do we want to move both of them to number here?

@cieslarmichal
Copy link
Owner Author

Hello @gagankonana there should be only one octal function in repo, the guarantee one is legacy and already removed from header file (some leftovers in cpp file), could you please remove leftovers of guarantee overload?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move "octal" from string to number module gagankonana/faker-cxx
2 participants
@cieslarmichal @gagankonana