Skip to content

Commit 97ba6a1

Browse files
committed
Re-enable implementation_imports lint rule.
1 parent fa22cf5 commit 97ba6a1

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

packages/flutter_tools/flutter_analysis_options

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ linter:
3636
# - constant_identifier_names # https://github.com/dart-lang/linter/issues/204 (and 203)
3737
- empty_constructor_bodies
3838
- hash_and_equals
39-
# - implementation_imports # https://github.com/dart-lang/linter/issues/203
39+
- implementation_imports
4040
- library_names
4141
- library_prefixes
4242
- non_constant_identifier_names

packages/flutter_tools/lib/src/dart/analysis.dart

+9-9
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,17 @@ import 'package:analyzer/plugin/options.dart';
1111
import 'package:analyzer/source/analysis_options_provider.dart';
1212
import 'package:analyzer/source/embedder.dart';
1313
import 'package:analyzer/source/error_processor.dart';
14-
import 'package:analyzer/src/generated/engine.dart';
15-
import 'package:analyzer/src/generated/error.dart';
16-
import 'package:analyzer/src/generated/java_io.dart';
17-
import 'package:analyzer/src/generated/sdk_io.dart';
18-
import 'package:analyzer/src/generated/source.dart';
19-
import 'package:analyzer/src/generated/source_io.dart';
20-
import 'package:analyzer/src/task/options.dart';
14+
import 'package:analyzer/src/generated/engine.dart'; // ignore: implementation_imports
15+
import 'package:analyzer/src/generated/error.dart'; // ignore: implementation_imports
16+
import 'package:analyzer/src/generated/java_io.dart'; // ignore: implementation_imports
17+
import 'package:analyzer/src/generated/sdk_io.dart'; // ignore: implementation_imports
18+
import 'package:analyzer/src/generated/source.dart'; // ignore: implementation_imports
19+
import 'package:analyzer/src/generated/source_io.dart'; // ignore: implementation_imports
20+
import 'package:analyzer/src/task/options.dart'; // ignore: implementation_imports
2121
import 'package:cli_util/cli_util.dart' as cli_util;
22-
import 'package:linter/src/plugin/linter_plugin.dart';
22+
import 'package:linter/src/plugin/linter_plugin.dart'; // ignore: implementation_imports
2323
import 'package:package_config/packages.dart' show Packages;
24-
import 'package:package_config/src/packages_impl.dart' show MapPackages;
24+
import 'package:package_config/src/packages_impl.dart' show MapPackages; // ignore: implementation_imports
2525
import 'package:path/path.dart' as path;
2626
import 'package:plugin/manager.dart';
2727
import 'package:plugin/plugin.dart';

packages/flutter_tools/lib/src/usage.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import 'dart:async';
66

7-
import 'package:usage/src/usage_impl_io.dart';
7+
import 'package:usage/src/usage_impl_io.dart'; // ignore: implementation_imports
88
import 'package:usage/usage.dart';
99

1010
import 'base/context.dart';

0 commit comments

Comments
 (0)